EIP-2929: only add params.address to access list

[sorpaas]

No matter if this is actually the issue for #353, it looks like a deviation from the specification nonetheless. The spec only specifies that we add the target address to the access list, but never mentioned params.sender.

[jochem-brouwer]

?

[sorpaas]

@jochem-brouwer No. That specifies what happens when you initialize a new transaction, but the lines in this PR is when you enter a substate call/create. They're entirely different.

[jochem-brouwer]

Ah - right, in that case you are correct. But this should not change stuff, since sender should already be in the warm access lists, as it was previously target of a message call/create or a *CALL* / CREATE* opcode.

[sorpaas]

That's not entirely true. I however indeed hope what you said is correct and this is actually just a no-op deviation.

params.sender is the caller of parent contract, not the transaction sender (which is params.origin). In the case of CALLCODE or DELEGATECALL, only params.code_address is added to the access list.

[jochem-brouwer]

True - sorry, I indeed meant the parent caller here, not tx.sender / ORIGIN.