Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency com.google.api-client:google-api-client to v1.32.1 #3203

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 13, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Update Change
com.google.api-client:google-api-client minor 1.30.11 -> 1.32.1

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@edalex-ian
Copy link
Member

Fails with:

[error] /home/runner/work/openEQUELLA/openEQUELLA/Source/Plugins/Core/com.equella.core/src/com/tle/core/google/GoogleServiceImpl.java:25:1: package com.google.api.client.json.jackson2 does not exist
[error] com.google.api.client.json.jackson2.JacksonFactory

Which is rather odd. Be interesting to see why Jackson from google is being used rather than directly.

@PenghaiZhang
Copy link
Contributor

PenghaiZhang commented Aug 11, 2021

Fails with:

[error] /home/runner/work/openEQUELLA/openEQUELLA/Source/Plugins/Core/com.equella.core/src/com/tle/core/google/GoogleServiceImpl.java:25:1: package com.google.api.client.json.jackson2 does not exist
[error] com.google.api.client.json.jackson2.JacksonFactory

Which is rather odd. Be interesting to see why Jackson from google is being used rather than directly.

They decoded to use Gson instead probably for security concerns.

googleapis/google-api-java-client#1661

GoogleContainerTools/jib#2951

@PenghaiZhang
Copy link
Contributor

GTG

Copy link
Member

@edalex-ian edalex-ian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice polish @PenghaiZhang

Merge on! 👍

@edalex-ian edalex-ian merged commit 167da9c into develop Aug 12, 2021
@edalex-ian edalex-ian deleted the renovate/com.google.api-client-google-api-client-1.x branch August 12, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants