Fix broken rf transmit behaviour in this version #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) The emonhub configuration for mqtt has both sub and pub - change the if statement at line 256 to allow this 2) Add tx/# to the mqtt subscribe at line 260 3) rf sendving via nodeval has 5 topic parts not 4, fix line 304 (see below) 4) Reinstate if statements: if topic_parts[0] == self._settings["nodevar_format_basetopic"][:-1]: and if topic_parts[0] == self._settings["node_format_basetopic"][:-1]: to avoid incorrect "Payload format error" messages To transmit via MQTT, example for emonglcd: topic:emonhub/tx/0/values/msg payload:10,14,49,25,27,04,24,150,835,1600,502
|
Thanks @alandpearson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I did some testing with this and found RF transmit no longer works,
Here is the fix.
Thanks
if topic_parts[0] == self._settings["nodevar_format_basetopic"][:-1]:
and
if topic_parts[0] == self._settings["node_format_basetopic"][:-1]:
to avoid incorrect "Payload format error" messages
To transmit via MQTT, example for emonglcd:
topic: emonhub/tx/0/values/msg
example payload:10,14,49,25,27,04,24,150,835,1600,502