Fix EmonHubMqttInterfacer.py crash when transmitting via RF (required for emonglcd etc.) #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unnoticed. This causes EmonHubMqttInterfacer.py to crash when using RF send functionality (used for emonPiGLCD). Line 265: msg.payload,decode() should be msg.payload.decode() (note , instead of .) Additionally a further crash fixed at line 268 (_log.debug, msg.payload not a string)
This makes a big difference on lower powered hardware e.g. pizero and pi3b, and also allows more throughput with emonhub, as well as being much more efficient. A discussion on this last year: https://community.openenergymonitor.org/t/emonhub-reduce-cpu-usage/22857/26
correctly appended when sending to serial) Remove spurious trailing comma from end of payload string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A typo appears to have made in my last commit 2 years ago, which went unnoticed.
This causes EmonHubMqttInterfacer.py to crash when using RF send functionality (used for emonPiGLCD).
Line 265:
msg.payload,decode() should be msg.payload.decode() (note comma instead of period)
and a further crash fixed at line 268 (_log.debug, msg.payload is not a string)
Additionally, EmonHubOEMInterfacer sending was updated to use existing send_cmd function instead of sending directly to serial port (to ensure "\n" is correctly appended) and remove spurious trailing comma from the end of cmd string.