fix: ccda zip import and php warnings and deprecations #7416
Conversation
|
At L-1015 in interface/modules/zend_modules/module/Carecoordination/src/Carecoordination/Controller/CarecoordinationController.php This will fix issue with zip though only tested to depth of 1 dir. |
stephenwaite
changed the title
| if (!empty($this->templateData['field_name_value_array']['encounter'][$i])) { | ||
| $this->templateData['field_name_value_array']['encounter'][$i]['extension'] = $entry['encounter']['id']['extension']; | ||
| $this->templateData['field_name_value_array']['encounter'][$i]['root'] = $entry['encounter']['id']['root']; | ||
| $this->templateData['field_name_value_array']['encounter'][$i]['date'] = ($entry['encounter']['effectiveTime']['value'] ?? null) ?: $entry['encounter']['effectiveTime']['low']['value'] ?? null; | ||
| $this->templateData['field_name_value_array']['encounter'][$i]['date_end'] = $entry['encounter']['effectiveTime']['high']['value'] ?? null; | ||
| } |
There was a problem hiding this comment.
Can't do. This may/will initially be empty but is init'ed by import data.
This is the parser for the import and the $this->templateData is unknowable and we should allow all arrays to be populated even with empty or null because those values may be a trigger in the actual DB import which happens after user reviews.
Please remove all conditionals put in and allow those arrays be init'ed. If they aren't they may end up causing warnings in DB import if they are expected but not there.
I hope I've been clear and if not please let me know.
There was a problem hiding this comment.
Looks like this is only place that concerns me otherwise thanks for fixing these.
There was a problem hiding this comment.
Just want to show how this break encounters. Otherwise import to patient is working better than I hoped but I see on area I need to investigate, vitals only populates using first encounter and not all vitals which I do parse and show in ccda.
I may do some fixes and push to your branch if that's okay?
There was a problem hiding this comment.
You'd think Stephen I'd have better things to do besides picking on!:)
There was a problem hiding this comment.
Never mind! Just be sure to revert above so import doesn't break.
|
thank you @sjpadgett ! |
* fix: php warns, deprecates * fix: php warns, deprecates openemr-cmd irp * check for non zero component count to start ccda zip import * fix couple other php warnings * remove conditional per Jerry's review
|
|
…_last * 'master' of https://github.com/openemr/openemr: Hide dashboard card 2 (openemr#7423) fix: ccda zip import and php warnings and deprecations (openemr#7416) Fee sheet and Codes revenue code (openemr#7415) Refactor UB04 837i X12 feature to make work again. (openemr#7412) feat: support loop 2420E (openemr#7405) Fix: Revert "Fix: OpenEMR logs sensitive information such as payment details (openemr#7341)" (openemr#7396) Weno better error handling from fetches (openemr#7408)
Fixes #7411 #7417
Short description of what this resolves:
Changes proposed in this pull request: