New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dorn Changes #7221
base: master
Are you sure you want to change the base?
Dorn Changes #7221
Conversation
if more than one come back on a check. Increased table column size too, truncation was happening
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module listeners for claims and DORN.
/* | ||
$classLoader = new \OpenEMR\Core\ModulesClassLoader($GLOBALS['fileroot']); | ||
$classLoader->registerNamespaceIfNotExists("OpenEMR\\Modules\\ClaimRevConnector\\", __DIR__ . DIRECTORY_SEPARATOR . 'src'); | ||
*/ | ||
|
||
use OpenEMR\Core\AbstractModuleActionListener; | ||
use OpenEMR\Modules\WenoModule\Services\ModuleService; | ||
|
||
/* Allows maintenance of background tasks depending on Module Manager action. */ | ||
|
||
class ModuleManagerListener extends AbstractModuleActionListener |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claimrevolution
I added this to your claim module which I setup to handle background service tasks.
It tested well for me!
Recommend you review and test!
/* | ||
$classLoader = new \OpenEMR\Core\ModulesClassLoader($GLOBALS['fileroot']); | ||
$classLoader->registerNamespaceIfNotExists("OpenEMR\\Modules\\Dorn\\", __DIR__ . DIRECTORY_SEPARATOR . 'src'); | ||
*/ | ||
|
||
use OpenEMR\Core\AbstractModuleActionListener; | ||
use OpenEMR\Modules\WenoModule\Services\ModuleService; | ||
|
||
/* Allows maintenance of background tasks depending on Module Manager action. */ | ||
|
||
class ModuleManagerListener extends AbstractModuleActionListener |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since no background services don't really need but has some useful functions you may want to implement to help manage module Delete if you want.
@claimrevolution If you want me to test then I need all the current test credentials for provider and api! |
} | ||
} | ||
ConnectorApi::setCompendiumLastUpdate($labGuid); | ||
echo "Compendium has been updated for lab: " . $compendiumResponse->compendium->labName; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text() on the variable above
ConnectorApi::setCompendiumLastUpdate($labGuid); | ||
echo "Compendium has been updated for lab: " . $compendiumResponse->compendium->labName; | ||
} else { | ||
echo "Error Getting Compendium! " . $compendiumResponse->responseMessage; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text() on the variable above
review complete :) |
lol I can look at a script a hundred times and still miss an escape! |
Fix js error for incomplete dialog title
@claimrevolution After setting up route I was able to download compendium. I didn't have an account so I used the lab guid.
So I think all I need is lab account for Autolab or maybe not. I'm getting excited to see this project work. |
I'm getting the same error. I reached out to dorn to see what the deal is. As far as the account number, it doesn't matter in testing. I use a random key on the keyboard like "asdf3". Anyway, I got the same error you are and I emailed them the other day and now just waiting.
I checked routes and account numbers in the route api and everything looked fine. This happened before and they did something and it started working again.
Brad Sharp
CTO
Cell: 918-943-0020
Office: 918-842-9564
Bixby, OK
www.claimrev.com<http://www.claimrev.com/>
Book a Demo<https://www.claimrev.com/schedule-demo/>
…________________________________
From: Jerry Padgett ***@***.***>
Sent: Friday, April 12, 2024 4:01 PM
To: openemr/openemr ***@***.***>
Cc: Brad Sharp ***@***.***>; Mention ***@***.***>
Subject: Re: [openemr/openemr] Dorn Changes (PR #7221)
@claimrevolution<https://github.com/claimrevolution> After setting up route I was able to download compendium. I didn't have an account so I used the lab guid.
So on transmit order I received an error of No account, lab guid etc.
Is their an account number I can use?
* I really like how you auto setup Provider, easy stuff! Still for hl7 orders you'll need a couple params in provider provided.
* I'm going to try to find a couple test my clinic can use so we may be able to use it for DORN cert. I'll send you a list and we can shop a lab.
* If you'll allow me I'd like to duplicate your setup in module or at least collect credentials so perhaps you can test if proper settings are in place before allow the module to start up.
* I noted that routes are in a table they will still persist in compendium search when deleted in DB. Maybe you are maintaining elsewhere.
* Noted too that while setting D for providers mode in globals the provider is created with P.
* echoing to dialog text for status if you don't format to take into account themes user will miss message i.e dark theme
Many of these minor things I can take care of.
So I think all I need is lab account for Autolab or maybe not.
I'm getting excited to see this project work.
—
Reply to this email directly, view it on GitHub<#7221 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJA7JDEXOSJKADDDN64INUTY5BDRDAVCNFSM6AAAAABDD2PE4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJSGUZDKNJWGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
ALERT: EMAIL EXTERNAL TO ORGANIZATION - VERIFY BEFORE ACTING
|
@claimrevolution |
I've added better error messages, to the return of the labs.
also for this test your account number needs to be: 1232e5When the route is setup the provider is updated, autolab in this case. The Sending Facility Name isn't populated and should be. It will give an error saying the MSH4 is empty.
Finally I'm geting an error message now that the account number doesn't match what is in the API. I've done a check and validated the route in DORN and the account number is 1232e5 but it doesn't seem to recognize it. Emailing DORN now.
Brad Sharp
CTO
Cell: 918-943-0020
Office: 918-842-9564
Bixby, OK
www.claimrev.com<http://www.claimrev.com/>
Book a Demo<https://www.claimrev.com/schedule-demo/>
…________________________________
From: Jerry Padgett ***@***.***>
Sent: Tuesday, April 16, 2024 8:03 PM
To: openemr/openemr ***@***.***>
Cc: Brad Sharp ***@***.***>; Mention ***@***.***>
Subject: Re: [openemr/openemr] Dorn Changes (PR #7221)
@claimrevolution<https://github.com/claimrevolution>
I'm tired and won't be working tonight but I've scheduled all day tomorrow to work this. I reviewed HL7 and looks okay to me so far.
Do you have some TODO's I can help you with? Just list them here or email.
Otherwise I'll probably be doings UX and stylings. Maybe some error reporting.
Let me know!
—
Reply to this email directly, view it on GitHub<#7221 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJA7JDFXEGVRFIPBK2OKB2TY5XC4TAVCNFSM6AAAAABDD2PE4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRQGE2TIOJZHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
ALERT: EMAIL EXTERNAL TO ORGANIZATION - VERIFY BEFORE ACTING
|
- no major changes to hl7. mostly code cleanup from auto tools.
@claimrevolution |
Looks like you have the AOE covered in code but I'm not seeing DORN sending the questions! |
Fixes #
Short description of what this resolves:
These are the changes for DORN.
Changes proposed in this pull request: