Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dorn Changes #7221

Open
wants to merge 61 commits into
base: master
Choose a base branch
from
Open

Dorn Changes #7221

wants to merge 61 commits into from

Conversation

claimrevolution
Copy link
Sponsor Contributor

Fixes #

Short description of what this resolves:

These are the changes for DORN.

Changes proposed in this pull request:

Copy link
Sponsor Member

@sjpadgett sjpadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module listeners for claims and DORN.

Comment on lines +28 to +38
/*
$classLoader = new \OpenEMR\Core\ModulesClassLoader($GLOBALS['fileroot']);
$classLoader->registerNamespaceIfNotExists("OpenEMR\\Modules\\ClaimRevConnector\\", __DIR__ . DIRECTORY_SEPARATOR . 'src');
*/

use OpenEMR\Core\AbstractModuleActionListener;
use OpenEMR\Modules\WenoModule\Services\ModuleService;

/* Allows maintenance of background tasks depending on Module Manager action. */

class ModuleManagerListener extends AbstractModuleActionListener
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claimrevolution
I added this to your claim module which I setup to handle background service tasks.
It tested well for me!
Recommend you review and test!

Comment on lines +28 to +38
/*
$classLoader = new \OpenEMR\Core\ModulesClassLoader($GLOBALS['fileroot']);
$classLoader->registerNamespaceIfNotExists("OpenEMR\\Modules\\Dorn\\", __DIR__ . DIRECTORY_SEPARATOR . 'src');
*/

use OpenEMR\Core\AbstractModuleActionListener;
use OpenEMR\Modules\WenoModule\Services\ModuleService;

/* Allows maintenance of background tasks depending on Module Manager action. */

class ModuleManagerListener extends AbstractModuleActionListener
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since no background services don't really need but has some useful functions you may want to implement to help manage module Delete if you want.

@sjpadgett
Copy link
Sponsor Member

@claimrevolution If you want me to test then I need all the current test credentials for provider and api!
I'm getting ready to move on! This PR is close to being ready for merge...

}
}
ConnectorApi::setCompendiumLastUpdate($labGuid);
echo "Compendium has been updated for lab: " . $compendiumResponse->compendium->labName;
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text() on the variable above

ConnectorApi::setCompendiumLastUpdate($labGuid);
echo "Compendium has been updated for lab: " . $compendiumResponse->compendium->labName;
} else {
echo "Error Getting Compendium! " . $compendiumResponse->responseMessage;
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text() on the variable above

@bradymiller
Copy link
Sponsor Member

review complete :)

@sjpadgett
Copy link
Sponsor Member

lol I can look at a script a hundred times and still miss an escape!
I do fine if I write it. This is why I don't often review others work, I'm horrible at it!
Thanks for the review. Now testing

@sjpadgett sjpadgett marked this pull request as draft April 9, 2024 16:14
Fix js error for incomplete dialog title
@sjpadgett sjpadgett marked this pull request as ready for review April 10, 2024 16:34
@sjpadgett
Copy link
Sponsor Member

@claimrevolution After setting up route I was able to download compendium. I didn't have an account so I used the lab guid.
So on transmit order I received an error of No account, lab guid etc.
Is their an account number I can use?

  • I really like how you auto setup Provider, easy stuff! Still for hl7 orders you'll need a couple params in provider provided.
  • I'm going to try to find a couple test my clinic can use so we may be able to use it for DORN cert. I'll send you a list and we can shop a lab.
  • If you'll allow me I'd like to duplicate your setup in module or at least collect credentials so perhaps you can test if proper settings are in place before allow the module to start up.
  • I noted that routes are in a table they will still persist in compendium search when deleted in DB. Maybe you are maintaining elsewhere.
  • Noted too that while setting D for providers mode in globals the provider is created with P.
  • echoing to dialog text for status if you don't format to take into account themes user will miss message i.e dark theme
    Many of these minor things I can take care of.

So I think all I need is lab account for Autolab or maybe not.

I'm getting excited to see this project work.

@claimrevolution
Copy link
Sponsor Contributor Author

claimrevolution commented Apr 12, 2024 via email

@sjpadgett
Copy link
Sponsor Member

@claimrevolution
I'm tired and won't be working tonight but I've scheduled all day tomorrow to work this. I reviewed HL7 and looks okay to me so far.
Do you have some TODO's I can help you with? Just list them here or email.
Otherwise I'll probably be doings UX and stylings. Maybe some error reporting.
Let me know!

@claimrevolution
Copy link
Sponsor Contributor Author

claimrevolution commented Apr 17, 2024 via email

- no major changes to hl7. mostly code cleanup from auto tools.
@sjpadgett
Copy link
Sponsor Member

@claimrevolution
I have orders being validated except AOE.
One or more validation errors occurred. Status:400 OBX: Test Code: '57021-8' is missing responses to the following required AOE question(s): 'What is your name?', 'Do you seek the Holy Grail?', 'What is your favorite color?' Generic Response: labGuid, accountNumber or lab test not found
If I remember, DORN sends the AOE in their JSON. Just needs to be parsed and saved to the procedure_answer table.

@sjpadgett
Copy link
Sponsor Member

Looks like you have the AOE covered in code but I'm not seeing DORN sending the questions!
Found an issue when sending an order with more than one test i.e sent all three then get No diagnosis present for the second set of two tests. Unknown why yet.

@adunsulag adunsulag added this to the 7.0.2.2 milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants