Cleanup lform directory and bug fixes (#6083)

* Cleanup lform directory
- Remove un-needed files left over by previous version of LHC-Forms

* - Update project to version 33.1.2
This fixes a rendering bug that errors in a render routine. Was introduced after v33.0.0.
See CHANGELOG

* - fix encounter delete to lookup correct questionnaire form name.

* - patch out append score to answers and re-build. LHC-Form.
Project admin just confirmed they are adding this change to project next release.

* - Quick fix to previous PR where elementIcon var is not in scope for an action set by click handler init.

* - fix missing date_created in ccda module settings for author
change user for authID as string

* - o'yeah the version bump

interface/patient_file/encounter/delete_form.php

@@ -95,8 +95,13 @@
 
                     <p>
                     <?php
-                    $formdir = $_GET["formname"];
-                    $formName = getFormNameByFormdir($formdir);
+                    $formdir = $_GET["formname"] ?? '';
+                    $form_id = $_GET["id"] ?? 0;
+                    if ($formdir == 'questionnaire_assessments') {
+                        $formName = sqlQuery("SELECT form_name FROM forms WHERE id = ? AND deleted = 0", array($form_id));
+                    } else {
+                        $formName = getFormNameByFormdir($formdir);
+                    }
                     echo xlt('You are about to delete the following form from this encounter') . ': ' . text(xl_form_title($formName["form_name"]));
                     ?>
                     </p>

sql/7_0_0-to-7_0_1_upgrade.sql

@@ -278,3 +278,11 @@ UPDATE `registry` SET `category` = 'Orders' WHERE `directory` = 'procedure_order
 #IfMissingColumn insurance_data date_end
 ALTER TABLE `insurance_data` ADD `date_end` date NULL;
 #EndIf
+
+#IfNotColumnType user user VARCHAR(255)
+ALTER TABLE `form_questionnaire_assessments` CHANGE `user` `user` VARCHAR(255) NULL DEFAULT NULL;
+#EndIf
+
+#IfMissingColumn module_configuration date_created
+ALTER TABLE `module_configuration` ADD COLUMN `date_created` DATETIME DEFAULT NULL COMMENT 'Datetime the record was created';
+#EndIf

sql/database.sql

@@ -6923,6 +6923,7 @@ CREATE TABLE `module_configuration` (
   `date_added` DATETIME DEFAULT NULL COMMENT 'Datetime the record was initially created',
   `updated_by` BIGINT(20) DEFAULT NULL COMMENT 'users.id the user that last modified this record',
   `date_modified` DATETIME DEFAULT CURRENT_TIMESTAMP COMMENT 'Datetime the record was last modified',
+  `date_created` DATETIME DEFAULT NULL COMMENT 'Datetime the record was created',
   PRIMARY KEY (`module_config_id`)
 ) ENGINE=InnoDB;
 
@@ -13219,7 +13220,7 @@ CREATE TABLE `form_questionnaire_assessments` (
   `date` datetime DEFAULT current_timestamp(),
   `response_id` TEXT COMMENT 'The foreign id to the questionnaire_response repository',
   `pid` bigint(21) NOT NULL DEFAULT 0,
-  `user` bigint(21) DEFAULT NULL,
+  `user` varchar(255) DEFAULT NULL,
   `groupname` varchar(255) DEFAULT NULL,
   `authorized` tinyint(4) NOT NULL DEFAULT 0,
   `activity` tinyint(4) NOT NULL DEFAULT 1,

src/OeUI/OemrUI.php

@@ -499,6 +499,8 @@ private function headerActionJs($arrAction = array())
         $action_top_js = <<<SHWTOP
         <script>
         $(function () {
+            let element = document.querySelector('a#show_hide i');
+            let elementIcon = document.querySelector('a#show_hide i');
             $labels
             $actionClasses
             $('#show_hide').click(function () {
@@ -541,8 +543,10 @@ private function headerActionJs($arrAction = array())
             // Because the hideaway is probably shown by default for a reason like in the billing manager
             if (shouldDisplay) {
                 document.querySelector('.hideaway').classList.remove('d-none');
-                elementIcon.classList.remove(showActionClass);
-                elementIcon.classList.add(hideActionClass);
+                if (document.getElementById(showActionClass) && document.getElementById(hideActionClass)) {
+                    elementIcon.classList.remove(showActionClass);
+                    elementIcon.classList.add(hideActionClass);
+                }
             }
         });
         </script>

version.php

@@ -28,7 +28,7 @@
 // is a database change in the course of development.  It is used
 // internally to determine when a database upgrade is needed.
 //
-$v_database = 484;
+$v_database = 485;
 
 // Access control version identifier, this is to be incremented whenever there
 // is a access control change in the course of development.  It is used