New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] fix: issue with custom searchfield bgcolor #2671
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @khudym! This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2671 +/- ##
==========================================
- Coverage 91.90% 91.83% -0.08%
==========================================
Files 235 235
Lines 4310 4224 -86
Branches 1044 1024 -20
==========================================
- Hits 3961 3879 -82
+ Misses 345 341 -4
Partials 4 4
☔ View full report in Codecov by Sentry. |
src/SearchField/index.scss
Outdated
background-color: unset; | ||
|
||
.pgn__searchfield_wrapper { | ||
background-color: $search-form-background-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[curious] Given it appears the Form.Control
component itself has a white background (see screenshot), I'm wondering if the .pgn__searchfield-form
's background color set on line 11 is actually needed?
Is an alternative solution here to remove the background-color: $search-form-background-color;
on .pgn__searchfield-form
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In PR on line 11 we added bg-color to cover issue with the background of labels and buttons, but with an external buttons it doesn`t work properly. If we just remove this line, the previous issue will occur, so the solution - to add styles separately for the searchfield labels and buttons.
fb37752
to
0490023
Compare
0490023
to
050cc48
Compare
@khudym I think you also need to add |
Description
update styles for SearchField
Issue
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist