Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update lock file version #2583

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mashal-m
Copy link
Contributor

Description

Renamed lockfileversion-check-v3 to lockfile-check in lockfile version file.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit ca23d86
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/64f033bbb37c1b0008182539
😎 Deploy Preview https://deploy-preview-2583--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d591994) 91.70% compared to head (ca23d86) 91.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2583   +/-   ##
=======================================
  Coverage   91.70%   91.70%           
=======================================
  Files         236      236           
  Lines        4219     4219           
  Branches     1021     1021           
=======================================
  Hits         3869     3869           
  Misses        346      346           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz
Copy link
Member

[clarification] @Mashal-m I'm assuming we'd want the failing mismatch-check to be passing before we merge this PR?

@Mashal-m Mashal-m marked this pull request as draft September 11, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants