feat: allow consumers to configure ModalDialog to allow overflow (#2939)

openedx · Feb 12, 2024 · 2801667 · 2801667
1 parent 163ce82
commit 2801667
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/Modal/ModalDialog.jsx b/src/Modal/ModalDialog.jsx
@@ -30,6 +30,7 @@ function ModalDialog({
   isFullscreenOnMobile,
   isBlocking,
   zIndex,
+  isOverflowVisible,
 }) {
   const isMobile = useMediaQuery({ query: '(max-width: 767.98px)' });
   const showFullScreen = (isFullscreenOnMobile && isMobile);
@@ -44,6 +45,7 @@ function ModalDialog({
             [`pgn__modal-${showFullScreen ? 'fullscreen' : size}`]: size,
             [`pgn__modal-${variant}`]: variant,
             'pgn__modal-scroll-fullscreen': isFullscreenScroll,
+            'pgn__modal-visible-overflow': isOverflowVisible,
           },
           className,
         )}
@@ -120,6 +122,8 @@ ModalDialog.propTypes = {
    * Specifies the z-index of the modal
    */
   zIndex: PropTypes.number,
+  /** Specifies whether overflow is visible in the modal */
+  isOverflowVisible: PropTypes.bool,
 };
 
 ModalDialog.defaultProps = {
@@ -133,6 +137,7 @@ ModalDialog.defaultProps = {
   isFullscreenOnMobile: false,
   isBlocking: false,
   zIndex: undefined,
+  isOverflowVisible: true,
 };
 
 ModalDialog.Header = ModalDialogHeader;

diff --git a/src/Modal/_ModalDialog.scss b/src/Modal/_ModalDialog.scss
@@ -38,6 +38,14 @@
       top: calc(#{$modal-inner-padding} / 2 * -1);
     }
   }
+
+  &.pgn__modal-visible-overflow {
+    overflow: visible;
+
+    .pgn__modal-body {
+      overflow: visible;
+    }
+  }
 }
 
 // Sizes
@@ -94,6 +102,8 @@
   justify-content: center;
   position: sticky;
   top: 0;
+  border-top-left-radius: $modal-content-border-radius;
+  border-top-right-radius: $modal-content-border-radius;
   padding: $modal-header-padding;
   background-color: $modal-content-bg;
   transition: box-shadow 150ms ease;