Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add key for suggestion items #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muneebGH
Copy link
Contributor

Merge checklist:

  • Ensure your commit message follows the semantic-release conventional commit message format
  • Once CI is passing, verify the package versions that Lerna will increment to in the Github Action CI workflow logs.
    • Note: This may be found in the "Preview Updated Versions (dry run)" step in the Github Action CI workflow logs.

Post merge:

  • Verify Lerna created a release commit (e.g., chore(release): publish) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions.
  • Run the Publish from package.json Github Action workflow to publish these new package versions to NPM.
    • This may be triggered by clicking the "Run workflow" option for the master branch.
  • Verify the new package versions were published to NPM (i.e., npm view <package_name> versions --json).
    • Note: There may be a slight delay between when the workflow finished and when NPM reports the package version as being published. If it doesn't appear right away in the above command, try again in a few minutes.

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #223 (42127ba) into master (09f3390) will decrease coverage by 0.68%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   72.38%   71.69%   -0.69%     
==========================================
  Files          33       31       -2     
  Lines         554      537      -17     
  Branches      129      127       -2     
==========================================
- Hits          401      385      -16     
+ Misses        139      138       -1     
  Partials       14       14              
Impacted Files Coverage Δ
packages/catalog-search/src/SearchBox.jsx 84.44% <0.00%> (-1.92%) ⬇️
packages/catalog-search/src/SearchSuggestions.jsx 100.00% <ø> (ø)
...ckages/catalog-search/src/SearchSuggestionItem.jsx 100.00% <100.00%> (ø)
packages/logistration/src/utils.js
packages/logistration/src/LoginRedirect.jsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f3390...42127ba. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant