Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Authn pages - fix background on medium resolutions [master] #1192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lunyachek
Copy link
Contributor

Description

At some resolutions, we can see this bug. It's related to the SVG image having a specific height, and at certain page sizes, this height isn't enough for the SVG to reach the bottom of the page. We suggest drawing a slanted background using CSS

How Has This Been Tested?

Locally, in different browsers and resolutions (Screenshots below)

Before
Снимок экрана 2024-03-05 в 15 59 26

After
Снимок экрана 2024-03-05 в 16 04 56

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/2u-vanguards to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@Lunyachek Lunyachek requested a review from a team as a code owner March 5, 2024 14:13
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 5, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Lunyachek Lunyachek changed the title fix: Authn pages - fix background on medium resolutions fix: Authn pages - fix background on medium resolutions [master] Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (90ae870) to head (2d96064).
Report is 7 commits behind head on master.

❗ Current head 2d96064 differs from pull request most recent head 5b1e63a. Consider uploading reports for the commit 5b1e63a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1192      +/-   ##
==========================================
- Coverage   87.71%   84.26%   -3.46%     
==========================================
  Files         124      126       +2     
  Lines        2288     2390     +102     
  Branches      636      678      +42     
==========================================
+ Hits         2007     2014       +7     
- Misses        272      356      +84     
- Partials        9       20      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arbrandes arbrandes self-requested a review March 5, 2024 15:32
@arbrandes arbrandes added the bug Report of or fix for something that isn't working as intended label Mar 5, 2024
@arbrandes
Copy link

I'm certainly in favor in principle, but is there any chance you could post screenshots of results on the major browsers (Chrome, Safari, Edge, Firefox)?

@zainab-amir
Copy link
Contributor

@Lunyachek can you kindly rebase your branch.

@Lunyachek Lunyachek force-pushed the lunyachek/fix/authn-page-background-fix-master branch from 2d96064 to 5b1e63a Compare April 18, 2024 21:39
@Lunyachek
Copy link
Contributor Author

Lunyachek commented Apr 18, 2024

@Lunyachek can you kindly rebase your branch.

Rebased. But I want to take more time to investigate one more small bug. I started taking screenshots in different browsers at different resolutions and found a strange bug with a vertical line.

Снимок экрана 2024-04-19 в 01 10 38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended open-source-contribution PR author is not from Axim or 2U
Projects
Status: In Eng Review
Status: In review
Development

Successfully merging this pull request may close these issues.

None yet

4 participants