New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Authn pages - fix background on medium resolutions [master] #1192
base: master
Are you sure you want to change the base?
fix: Authn pages - fix background on medium resolutions [master] #1192
Conversation
Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1192 +/- ##
==========================================
- Coverage 87.71% 84.26% -3.46%
==========================================
Files 124 126 +2
Lines 2288 2390 +102
Branches 636 678 +42
==========================================
+ Hits 2007 2014 +7
- Misses 272 356 +84
- Partials 9 20 +11 ☔ View full report in Codecov by Sentry. |
I'm certainly in favor in principle, but is there any chance you could post screenshots of results on the major browsers (Chrome, Safari, Edge, Firefox)? |
@Lunyachek can you kindly rebase your branch. |
2d96064
to
5b1e63a
Compare
Rebased. But I want to take more time to investigate one more small bug. I started taking screenshots in different browsers at different resolutions and found a strange bug with a vertical line. |
Description
At some resolutions, we can see this bug. It's related to the SVG image having a specific height, and at certain page sizes, this height isn't enough for the SVG to reach the bottom of the page. We suggest drawing a slanted background using CSS
How Has This Been Tested?
Locally, in different browsers and resolutions (Screenshots below)
Before
After
Merge Checklist
Post-merge Checklist