Rebuild node-sass before compiling Sass #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to go ahead and merge this to make it easier for @cpennington to resolve CI failures related to course discovery. |
rlucioni
pushed a commit
that referenced
this pull request
Dec 18, 2015
Rebuild node-sass before compiling Sass
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes CI build failures related to Programs Sass compilation. The issue at hand has been around for months; see sass/node-sass#918 and sass/node-sass#1162.
node-sassis a native module which compiles C++ code on installation. The failures observed in CI allegedly occur when the version ofnodewhich originally compiled the module differs from the version ofnodeused to run the module. This requires that the module be rebuilt.I experimented with sourcing the Programs
nodeenvand executingnpmdirectly instead of using Ansible'snpmmodule, just in case that was allowing a different version ofnodeto be used when installing dependencies. However, trial and error suggests this doesn't seem to be the case.@jibsheet please review.