Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go module migration #131

Closed
wants to merge 9 commits into from
Closed

Go module migration #131

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4a8ab23
changes to support go module
vaniisgh May 21, 2020
f83f57c
test update ci
vaniisgh May 23, 2020
0d45262
doc changes
vaniisgh May 23, 2020
838721e
- tried to fix ci file
vaniisgh Jun 3, 2020
fdab062
- adding vendor folder
vaniisgh Jun 4, 2020
32120b7
- adding vendor folder
vaniisgh Jun 4, 2020
4661127
- fix typo
vaniisgh Jun 4, 2020
862ea80
- update travis-ci
vaniisgh Jun 4, 2020
74f3dd3
Merge branch 'go_module_migration' of https://github.com/vaniisgh/zfs…
vaniisgh Jun 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
9 changes: 4 additions & 5 deletions .travis.yml
View file
Open in desktop
Expand Up @@ -23,11 +23,10 @@ before_install:
- truncate -s 100G /tmp/disk.img
- sudo zpool create -f zfspv-pool /tmp/disk.img
install:
- if [ "$TRAVIS_BUILD_DIR" != "$GOPATH/src/github.com/openebs/zfs-localpv" ]; then
mkdir -p $GOPATH/src/github.com/openebs/;
mv $TRAVIS_BUILD_DIR $GOPATH/src/github.com/openebs;
cd $GOPATH/src/github.com/openebs/zfs-localpv;
fi
- if [ "$TRAVIS_BUILD_DIR" != "$HOME/openebs/zfs-localpv" ]; then
mkdir -p $HOME/openebs/;
mv $TRAVIS_BUILD_DIR $HOME/openebs;
cd $HOME/openebs/zfs-localpv;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we don't need this anymore , we can remove this , travis handles the gopath correctly now.

Copy link
Contributor Author

@vaniisgh vaniisgh Jun 4, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can I just remove it completely then.i.e all lines from 26-29?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please

- make bootstrap
- make format
- curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/v1.16.0/bin/linux/amd64/kubectl
Expand Down