This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Added metrics publishing logic #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getsaurabh02
previously approved these changes
Mar 3, 2021
psychbot
changed the title
getsaurabh02
approved these changes
Mar 4, 2021
khushbr
pushed a commit
that referenced
this pull request
Jun 10, 2021
khushbr
pushed a commit
that referenced
this pull request
Jun 10, 2021
cr https://code.amazon.com/reviews/CR-50314382 commit 2eb3872b0d3bfde09719497440019eeb7061dd7b Merge: fa1ac709 a3877ba Author: Khushboo Rajput <khushbr@dev-dsk-khushbr-2c-06ad8e48.us-west-2.amazon.com> Date: Tue May 4 21:08:59 2021 -0700 Merge branch 'main' into aes_7.10_nightly commit fa1ac70933ae5c1939c4a0fa30f50f81925a07ab Merge: fac4f8b8 c70b19d Author: Khushboo Rajput <khushbr@dev-dsk-khushbr-2c-06ad8e48.us-west-2.amazon.com> Date: Tue May 4 21:04:35 2021 -0700 Merge branch 'aes_7.10_gh' into aes_7.10_nightly commit a3877ba Author: Sruti Parthiban <srutiparthiban@gmail.com> Date: Thu Apr 15 12:21:34 2021 -0700 Fix format error (#309) commit 7e0d2f8 Author: Sruti Parthiban <srutiparthiban@gmail.com> Date: Thu Apr 15 11:30:34 2021 -0700 Fix failing election term tests (#305) commit ea643fe Author: meetshah777 <48720201+meetshah777@users.noreply.github.com> Date: Thu Apr 1 02:29:45 2021 +0530 Changed master total PendingQueueSize to PendingQueueSize per task type (#296) * Changed master total PendingQueueSize to PendingQueueSize per task type * Addressed comments Co-authored-by: Meet Shah <meetsh@amazon.com> commit bf6a4cc Author: meetshah777 <48720201+meetshah777@users.noreply.github.com> Date: Thu Apr 1 02:27:24 2021 +0530 Added Election Term Metric (#297) * Changed master total PendingQueueSize to PendingQueueSize per task type * Added Election Term Metric * Formmated files * Merge conflict resolved * Addressed comments Co-authored-by: Meet Shah <meetsh@amazon.com> commit 130a494 Author: Mital Awachat <mitalawachat@users.noreply.github.com> Date: Thu Mar 25 23:35:49 2021 +0530 AdmissionControl: Clear metricQueue before running test (#300) Co-authored-by: Mital Awachat <awachatm@amazon.com> commit 3e6b8ec Author: Joshua Tokle <jtokle@gmail.com> Date: Wed Mar 24 19:07:06 2021 -0700 Configure spotless plugin and enable code formatting (#276) * Configure spotless plugin and enable code formatting * Remove checkstyle and @ignore flaky tests commit fac4f8b835e793e3db5240f1e4d1448fd9d16baa Merge: 253229a2 f7b430b Author: Khushboo Rajput <khushbr@dev-dsk-khushbr-2c-06ad8e48.us-west-2.amazon.com> Date: Tue Mar 23 17:14:37 2021 -0700 Merge branch 'main' into aes_7.10_nightly commit f7b430b Author: Dharmesh <sdharms@amazon.com> Date: Wed Mar 24 05:25:20 2021 +0530 [Build Fix]Removing the typecasting to IndexingPressure class to fix build failure while backporting (#293) commit d49a701 Author: amathur1893 <amathur1893@gmail.com> Date: Thu Mar 18 02:51:11 2021 +0530 Cluster state applier stats (#282) * Publish latency and failure metrics for cluster state applier thread * Publish latency and failure metrics for cluster state applier thread * Extract MetricsTracker * Add Javadoc for Metrics Tracker * Add ClusterStateApplierStats to collect latency and failure metrics * Add ClusterStateApplierStats to collect latency and failure metrics * Added UTs for ClusterApplierServiceStatsCollector * Added UTs for ClusterApplierServiceStatsCollector * Java doc changes Co-authored-by: Arpita Mathur <arpitamt@amazon.com> commit 253229a24f49b5479333d8ffda7167441e39162a Merge: 7c5cb8e6 52e5cc4 Author: Khushboo Rajput <khushbr@dev-dsk-khushbr-2c-06ad8e48.us-west-2.amazon.com> Date: Mon Mar 8 22:06:07 2021 -0800 Merge branch 'main' into aes_7.10_nightly commit 52e5cc4 Author: Mital Awachat <mitalawachat@users.noreply.github.com> Date: Tue Mar 9 10:49:11 2021 +0530 Track admission control metrics (#290) * Track admission control metrics Co-authored-by: Mital Awachat <awachatm@amazon.com> commit c280915 Author: Dharmesh <sdharms@amazon.com> Date: Thu Mar 4 23:12:37 2021 +0530 [Bug Fix] Incorrect metric value was returned from the getter of current bytes (#287) commit 7c5cb8e63cde9023084ab57075bbdf554df9748c Merge: 28ee8302 a997189 Author: Khushboo Rajput <khushbr@dev-dsk-khushbr-2c-06ad8e48.us-west-2.amazon.com> Date: Thu Mar 4 09:39:54 2021 -0800 Merge branch 'main' into aes_7.10_nightly commit a997189 Author: Dharmesh <sdharms@amazon.com> Date: Thu Mar 4 10:55:36 2021 +0530 Added metrics publishing logic (#285) commit 28ee8302529c279dfadc47bf9b0d4f6b6d91ac75 Author: Dharmesh <sdharms@amazon.com> Date: Tue Mar 2 23:49:47 2021 +0530 Adding a additional check to just process first 50 objects of hot store (#284) commit 0d2566a61bab1531400eaae486c3734bcea386fe Author: Dharmesh <12bce021@nirmauni.ac.in> Date: Tue Mar 2 11:33:35 2021 +0530 Changes to collect shard indexing pressure metrics and push to shared location (#278) * Changes to collect shard indexing pressure metrics and push to shared location * Code changes to remove pushing the cold store objects and removing isActiveShard flag as it becomes irrelevant now * Addressing comment to change NodeRole to IndexingStage as node role already has a predefined meaning * Checking if class is present while adding the collector in scheduled executor so that the collector will never be invoked if class in not present * Addressing comments. commit 819d485 Author: Dharmesh <sdharms@amazon.com> Date: Tue Mar 2 23:49:47 2021 +0530 Adding a additional check to just process first 50 objects of hot store (#284) commit 2f3df02 Author: Dharmesh <12bce021@nirmauni.ac.in> Date: Tue Mar 2 11:33:35 2021 +0530 Changes to collect shard indexing pressure metrics and push to shared location (#278) * Changes to collect shard indexing pressure metrics and push to shared location * Code changes to remove pushing the cold store objects and removing isActiveShard flag as it becomes irrelevant now * Addressing comment to change NodeRole to IndexingStage as node role already has a predefined meaning * Checking if class is present while adding the collector in scheduled executor so that the collector will never be invoked if class in not present * Addressing comments. commit 9f83059 Author: Yu Sun <11154022+yu-sun-77@users.noreply.github.com> Date: Fri Feb 26 14:36:02 2021 -0800 Log error once only (#280) commit 3377c2f Author: Karthik Kumarguru <52506191+ktkrg@users.noreply.github.com> Date: Mon Feb 22 15:11:45 2021 -0800 Increase the max heap limit to check against in the integ tests (#277) commit 641b403f941596f543e95a01b9a5795b73d7fd65 Author: Khushboo Rajput <khushbr@dev-dsk-khushbr-2c-06ad8e48.us-west-2.amazon.com> Date: Sat Feb 20 12:45:57 2021 -0800 Creating new brand for ES 7.10 version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Publishing Error and Writer metrics - opendistro-for-elasticsearch/performance-analyzer-rca#567
Related PR : opendistro-for-elasticsearch/performance-analyzer-rca#569
Description of changes:
Added the logic to publish the metrics for error and writer. Error metrics is published when there is any error that happens during parsing the hot store objects.
Testing
The collector is enabled by default and we can see the metrics once we enable the ES feature.
Once the collector is disabled we can see that there are no metrics even though the ES feature is enabled or disabled.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.