chore: adds godoc to Feature builder #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the first step of improving Feature DSL this PR brings godoc explaining purpose of each method in the builder chain.
bartoszmajsak
requested review from
VaishnaviHire and
cam-garrison
and removed request for
israel-hdez and
gmfrasca
|
@VaishnaviHire maybe we can think of introducing Rationale here is that we might save cloud resources/have smaller job queue for e2e testing. |
bartoszmajsak
requested review from
AjayJagan
and removed request for
cam-garrison
zdtsw
approved these changes
May 16, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5ce6306
into
opendatahub-io:incubation
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the first step of improving Feature DSL this PR brings godoc explaining purpose of each method in the builder chain.
How Has This Been Tested?
It's only
godocchanges + shuffling methods around, not sure have something to test here.Merge criteria: