upgrade: retry if default DSCI creation fails #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
1 similar comment
|
/retest |
zdtsw
approved these changes
May 14, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AjayJagan, zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
After removing leader election, operator fails to start if it is
instructed to create default DSCI. Looks like webhook is not ready
by the time:
```
create default DSCI CR.
{"level":"error","ts":"2024-05-13T09:25:58Z","logger":"setup","msg":"unable to create initial setup for the operator","error":"Internal error occurred: failed calling webhook \"operator.opendatahub.io\": failed to call webhook: Post \"https://opendatahub-operator-controller-manager-service.oo-2ts9m.svc:443/validate-opendatahub-io-v1?timeout=10s\": no endpoints available for service \"opendatahub-operator-controller-manager-service\"","stacktrace":"main.main.func1\n\t/workspace/main.go:200\nsigs.k8s.io/controller-runtime/pkg/manager.RunnableFunc.Start\n\t/remote-source/operator/deps/gomod/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/manager/manager.go:336\nsigs.k8s.io/controller-runtime/pkg/manager.(*runnableGroup).reconcile.func1\n\t/remote-source/operator/deps/gomod/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/manager/runnable_group.go:219"}
```
Leader election added some delay.
The problem does not happen in default configuration since it
explicitly disables DSCI creation in the manifests:
```
containers:
- command:
- /manager
env:
- name: DISABLE_DSC_CONFIG
value: 'true'
args:
- --operator-name=opendatahub
image: controller:latest
```
Make a wrapper function cluster.CreateWithRetry for client.Object
creation with timeout. Use hardcoded 5s interval, just seems
reasonable, and timeout in minutes as the parameter.
It requires disable linter nilerr since for the polling function
error in creation is a valid condition, something the function wait
to disappear.
Fixes: 3610b0b ("feat: remove leader election for operator (opendatahub-io#1000)")
Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta
force-pushed
the
dsci-creation-delay
branch
from
a7889fb
to
a892b10
Compare
|
Actually, generic is overthinking, taking interface here is enough. |
|
/retest |
|
/retest-required |
|
/lgtm |
openshift-merge-bot
bot
merged commit e26100e
into
opendatahub-io:incubation
8 checks passed
VaishnaviHire
added a commit
that referenced
this pull request
May 14, 2024
* Update version to v2.12.0 (#1007) * upgrade: retry if default DSCI creation fails (#1008) After removing leader election, operator fails to start if it is instructed to create default DSCI. Looks like webhook is not ready by the time: ``` create default DSCI CR. {"level":"error","ts":"2024-05-13T09:25:58Z","logger":"setup","msg":"unable to create initial setup for the operator","error":"Internal error occurred: failed calling webhook \"operator.opendatahub.io\": failed to call webhook: Post \"https://opendatahub-operator-controller-manager-service.oo-2ts9m.svc:443/validate-opendatahub-io-v1?timeout=10s\": no endpoints available for service \"opendatahub-operator-controller-manager-service\"","stacktrace":"main.main.func1\n\t/workspace/main.go:200\nsigs.k8s.io/controller-runtime/pkg/manager.RunnableFunc.Start\n\t/remote-source/operator/deps/gomod/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/manager/manager.go:336\nsigs.k8s.io/controller-runtime/pkg/manager.(*runnableGroup).reconcile.func1\n\t/remote-source/operator/deps/gomod/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/manager/runnable_group.go:219"} ``` Leader election added some delay. The problem does not happen in default configuration since it explicitly disables DSCI creation in the manifests: ``` containers: - command: - /manager env: - name: DISABLE_DSC_CONFIG value: 'true' args: - --operator-name=opendatahub image: controller:latest ``` Make a wrapper function cluster.CreateWithRetry for client.Object creation with timeout. Use hardcoded 5s interval, just seems reasonable, and timeout in minutes as the parameter. It requires disable linter nilerr since for the polling function error in creation is a valid condition, something the function wait to disappear. Fixes: 3610b0b ("feat: remove leader election for operator (#1000)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> --------- Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> Co-authored-by: Yauheni Kaliuta <ykaliuta@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After removing leader election, operator fails to start if it is instructed to create default DSCI. Looks like webhook is not ready by the time:
Leader election added some delay.
The problem does not happen in default configuration since it explicitly disables DSCI creation in the manifests:
Make a wrapper function cluster.CreateWithRetry for client.Object creation with timeout. Use 5s interval, just seems reasonable, and timeout in minutes as the parameter.
It requires disable linter nilerr since for the polling function error in creation is a valid condition, something the function wait to disappear.
Fixes: 3610b0b ("feat: remove leader election for operator (#1000)")
How Has This Been Tested?
Merge criteria: