add taskName parameter to parseRuntimeInfoFromExecutions function #2819
Conversation
…imeInfoFromExecutions add taskName parameter to parseRuntimeInfoFromExecutions function refactor: update parseUtils to handle taskName or taskId in parseRuntimeInfoFromExecutions
Gkrumbach07
force-pushed
the
bug/RHOAIENG-7079-pipeline-logs-are-inconsistent-with-what-is-availa
branch
from
6189510
to
dbaf361
Compare
| executions?: Execution[] | null, | ||
| ): PipelineTaskRunStatus | undefined => { | ||
| if (!executions) { | ||
| return undefined; | ||
| } | ||
|
|
||
| const execution = executions.find( | ||
| (e) => e.getCustomPropertiesMap().get('task_name')?.getStringValue() === taskId, | ||
| (e) => e.getCustomPropertiesMap().get('task_name')?.getStringValue() === (taskName || taskId), |
There was a problem hiding this comment.
If both of taskName & taskId props are required and not possibly undefined (since the type is simply string, this will always use the taskName. Maybe taskName is meant to be optional and just used to override the usage of taskId?
There was a problem hiding this comment.
not necessarily. I used || which will used the taskId if taskName is "", which is what i noticed in cases where the label is empty for some reason.
in JS:
a = "";
b = "defined"
a || b == "defined"
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jpuzz0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
closes: https://issues.redhat.com/browse/RHOAIENG-7079
Description
How Has This Been Tested?
Test Impact
none, small mlmd fix in for backend
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main