Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipeline version multi-select issue #2817

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented May 15, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-7077

Description

It's a one-liner fix, we read the wrong property in the object of a pipeline version to select the checkbox.
However, I updated a lot of the pipeline cypress test to make it make more sense. Thanks for the help of @christianvogt

How Has This Been Tested?

  1. Verify the multi-selection is working on the pipeline versions table
  2. Verify the batch deletion of pipeline version works

Test Impact

Updated the cypress test.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.30%. Comparing base (95611b7) to head (b4b1b2f).
Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2817      +/-   ##
==========================================
- Coverage   78.14%   77.30%   -0.85%     
==========================================
  Files        1076     1097      +21     
  Lines       22629    23083     +454     
  Branches     5722     5814      +92     
==========================================
+ Hits        17684    17844     +160     
- Misses       4945     5239     +294     
Files Coverage Δ
.../src/components/table/TableRowTitleDescription.tsx 92.85% <ø> (-0.90%) ⬇️
...ines/content/tables/pipeline/PipelinesTableRow.tsx 85.18% <ø> (ø)
...nt/tables/pipelineVersion/PipelineVersionTable.tsx 94.44% <ø> (ø)
...tables/pipelineVersion/PipelineVersionTableRow.tsx 100.00% <ø> (ø)
...ipelineVersion/usePipelineVersionsCheckboxTable.ts 88.88% <100.00%> (ø)

... and 47 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95611b7...b4b1b2f. Read the comment docs.

Copy link
Contributor

@jpuzz0 jpuzz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments. Otherwise, this looks good.

Copy link
Contributor

@jpuzz0 jpuzz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Gkrumbach07
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07, jpuzz0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2797e61 into opendatahub-io:main May 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants