Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] testing codecov #2808

Closed

Conversation

christianvogt
Copy link
Contributor

Do not merge.

Testing codecov with base report.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label May 10, 2024
@openshift-ci openshift-ci bot requested review from lucferbux and uidoyen May 10, 2024 20:14
Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from christianvogt. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 78.11%. Comparing base (37469fd) to head (6fdcc96).
Report is 20 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2808      +/-   ##
==========================================
- Coverage   78.14%   78.11%   -0.03%     
==========================================
  Files        1076     1076              
  Lines       22615    22623       +8     
  Branches     5718     5719       +1     
==========================================
  Hits        17673    17673              
- Misses       4942     4950       +8     
Files Coverage Δ
frontend/src/utilities/string.ts 85.45% <25.00%> (-10.30%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37469fd...6fdcc96. Read the comment docs.

@christianvogt christianvogt force-pushed the testing-codecov branch 3 times, most recently from 8463639 to a678caa Compare May 13, 2024 19:24
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress This PR is in WIP state needs-rebase PR needs to be rebased
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants