Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added core interceptor for pipeline #2794

Merged
merged 1 commit into from
May 17, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented May 9, 2024

Closes: https://issues.redhat.com/browse/RHOAIENG-5329

Description

continuation for updating interceptOdh for pipeline intercepts

How Has This Been Tested?

npm run test

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@pnaik1 pnaik1 requested a review from christianvogt May 9, 2024 15:29
@openshift-ci openshift-ci bot requested review from lucferbux and ppadti May 9, 2024 15:29
@pnaik1
Copy link
Contributor Author

pnaik1 commented May 10, 2024

/retest

1 similar comment
@pnaik1
Copy link
Contributor Author

pnaik1 commented May 10, 2024

/retest

Copy link
Contributor

@dpanshug dpanshug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnaik1
Copy link
Contributor Author

pnaik1 commented May 14, 2024

/retest

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.18%. Comparing base (95611b7) to head (68901d9).
Report is 18 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2794      +/-   ##
==========================================
- Coverage   78.14%   77.18%   -0.97%     
==========================================
  Files        1076     1098      +22     
  Lines       22629    23118     +489     
  Branches     5722     5815      +93     
==========================================
+ Hits        17684    17844     +160     
- Misses       4945     5274     +329     

see 52 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95611b7...68901d9. Read the comment docs.

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label May 14, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label May 15, 2024
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, dpanshug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 56910f3 into opendatahub-io:main May 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants