[RHOAIENG-6314] Add tracking for new Homepage. #2781
Conversation
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @pilhuhn. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
| @@ -24,11 +22,6 @@ const NewProjectButton: React.FC<NewProjectButtonProps> = ({ closeOnCreate, onPr | |||
| <ManageProjectModal | |||
| open={open} | |||
| onClose={(newProjectName) => { | |||
| fireTrackingEvent('NewProject Created', { | |||
There was a problem hiding this comment.
Why did you drop this?
There was a problem hiding this comment.
This is now handled inside the ManageProjectModal at https://github.com/opendatahub-io/odh-dashboard/pull/2781/files#diff-8827454ead4ff8421767576741c1ec341bf780e07671a2c37a34fd2677fbb7caR51 , because the Modal is called from multiple places.
There was a problem hiding this comment.
@pilhuhn there are 5 use cases of NewProjectButton -- you point at solving 1. What about the other 4?
There was a problem hiding this comment.
I only ask because we sound like we are losing overall tracking, to get tracking for the home page
There was a problem hiding this comment.
I'll have a look in a minute (once the tranisition to the new laptop is kind of finished). Moving the tracking code inside ManagedProjectModal should catch them all. Before there was this button and also the new NewProject link on the new home page.
There was a problem hiding this comment.
@andrewballantyne I am not sure I understand your question. The tracking code has moved from NewProjectButton into ManageProjectModal, which is part of the internal implementation of the NewProjectButton.
I did that because the ProjectsSection is using the modal directly and not via NewProjectButton.
There was a problem hiding this comment.
I misunderstood it when I briefly was looking at it earlier. Thanks for the clarification.
|
This PR looks good -- just one question (see my message earlier) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This adds tracking for the new home page. As part of this, trackign of the new project
button has moved from the NewProjectButton to the ManageProjectsModal.
[RHOAIENG-6314]
How Has This Been Tested?
By hand and by watching the browser console.
Test Impact
Functionality of the UI has not changed.
Request review criteria:
Self checklist (all need to be checked):
After the PR is posted & before it merges:
main