[RHOAIENG-5497] Enable the landing page

[jeff-phillips-18]

Closes: RHOAIENG-5497

Description

Changes the default for disableHome to true in the dashboard config thus enabling the new Landing Page by default.

How Has This Been Tested?

Tested locally

Test Impact

Updated tests to verify that the default state shows the landing page.

Request review criteria:

• The developer has manually tested the changes and verified that the changes work
• Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

[andrewballantyne]

/hold

Needs a review from PM before we enable it for the product.

[andrewballantyne]

I don't understand why you changed this... the home page can still be disabled

[jeff-phillips-18]

I could add it back but it's not set in any of the callers.

[andrewballantyne]

You had a test to make sure the URL redirect was properly tested with and without the feature enabled. I'm feeling you had to have dropped something or we are missing something if it's no longer used.

This cannot be right I would think 🤔 Not sure where the gap is...

[jeff-phillips-18]

I changed the test to verify that / takes you to the enabled page if the flag is disabled:
https://github.com/opendatahub-io/odh-dashboard/pull/2767/files#diff-34ec9e23c634748dc1ed7b69552b385bf9a11a5a746b7e4779c48e3302f9699aR19

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.40%. Comparing base (1c223b6) to head (add90d9).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2767      +/-   ##
==========================================
- Coverage   77.40%   77.40%   -0.01%     
==========================================
  Files        1101     1101              
  Lines       23176    23176              
  Branches     5843     5843              
==========================================
- Hits        17940    17939       -1     
- Misses       5236     5237       +1     

see 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c223b6...add90d9. Read the comment docs.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment