-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update kustomize to remove depreciated features #1983
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @strangiato. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
mm @zdtsw @VaishnaviHire do Operator v2 (i can test it later if you are not sure) support the I tested a few months ago, just before the operator redesign, to change that for the rhods overlay and it broke, that's why I added both the |
Also, @strangiato I'm sorry cause we've had this on stale for a long time so now we have a conflict, can you resolve the issue with |
Closing this, we will cover this as part of the Platform issue: https://issues.redhat.com/browse/RHOAIENG-6716 |
Description
This update resolves several depreciation warnings for kustomize that the operator generates while applying the manifests.
How Has This Been Tested?
Generate all of the manifests from main, then generate the manifests from the updated version. The generated manifests should 100% match.
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main