Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kustomize to remove depreciated features #1983

Closed

Conversation

strangiato
Copy link
Contributor

Description

This update resolves several depreciation warnings for kustomize that the operator generates while applying the manifests.

How Has This Been Tested?

Generate all of the manifests from main, then generate the manifests from the updated version. The generated manifests should 100% match.

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [n/a] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • [n/a] Included any necessary screenshots or gifs if it was a UI change.
  • [n/a] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from pnaik1 and ppadti October 18, 2023 23:11
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign christianvogt for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI label Oct 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

Hi @strangiato. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewballantyne
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests. and removed needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI labels Oct 19, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Nov 19, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lucferbux
Copy link
Contributor

mm @zdtsw @VaishnaviHire do Operator v2 (i can test it later if you are not sure) support the resrouces label rather than base for overlays?

I tested a few months ago, just before the operator redesign, to change that for the rhods overlay and it broke, that's why I added both the incubation and rhods overlays as base. If we are ok with that in the operator side I think we can be ready to go.

@lucferbux
Copy link
Contributor

lucferbux commented Nov 21, 2023

Also, @strangiato I'm sorry cause we've had this on stale for a long time so now we have a conflict, can you resolve the issue with manifest/modelserving/kustomization.yaml please? Thanks in advance!

@andrewballantyne
Copy link
Member

Closing this, we will cover this as part of the Platform issue: https://issues.redhat.com/browse/RHOAIENG-6716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase PR needs to be rebased ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants