Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple GitOps Update pipeline from aiedge-e2e #267

Merged
merged 3 commits into from
May 30, 2024

Conversation

grdryn
Copy link
Member

@grdryn grdryn commented May 16, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-4982

Description

Before this change, at least one PipelineRun for the specified model name from the aiedge-e2e Pipeline needed to exist on the cluster, to be able to successfully run the GitOps Update Pipeline.

This change instead accepts the image details explicitly as parameters in the GitOps Update Pipeline, making it more robust and applicable to more scenarios.

How Has This Been Tested?

  • Tested that all of the updated pipelinerun examples work as expected.
  • Observed that the e2e test passes on this PR.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

JIRA: https://issues.redhat.com/browse/RHOAIENG-4982

Before this change, at least one PipelineRun for the specified model
name from the aiedge-e2e Pipeline needed to exist on the cluster, to
be able to successfully run the GitOps Update Pipeline.

This change instead accepts the image details explicitly as parameters
in the GitOps Update Pipeline, making it more robust and applicable to
more scenarios.
Copy link

openshift-ci bot commented May 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@grdryn grdryn marked this pull request as ready for review May 16, 2024 11:17
@grdryn grdryn changed the title Decouple GitOps Update pipeline from aiedge-e2e [WIP] Decouple GitOps Update pipeline from aiedge-e2e May 16, 2024
@grdryn grdryn changed the title [WIP] Decouple GitOps Update pipeline from aiedge-e2e Decouple GitOps Update pipeline from aiedge-e2e May 21, 2024
@MarianMacik MarianMacik self-requested a review May 23, 2024 21:55
Copy link
Member

@MarianMacik MarianMacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have just opened grdryn#36 to fix the tests. The explanation why the tests didn't fail here is in that PR. Now it should be OK and the tests would catch it. After that PR is merged, we can merge this too.

Update shell tests to work with gitops-update-pipeline changes
Copy link
Member

@MarianMacik MarianMacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@LaVLaS
Copy link
Member

LaVLaS commented May 30, 2024

/approved

This worked for me without issues and no requirement for a pre-existing successful pipelinerun

Copy link
Member

@LaVLaS LaVLaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

openshift-ci bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 36f88b8 into opendatahub-io:main May 30, 2024
2 checks passed
@grdryn grdryn deleted the rhoaieng-4982 branch May 30, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants