-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple GitOps Update pipeline from aiedge-e2e #267
Decouple GitOps Update pipeline from aiedge-e2e #267
Conversation
JIRA: https://issues.redhat.com/browse/RHOAIENG-4982 Before this change, at least one PipelineRun for the specified model name from the aiedge-e2e Pipeline needed to exist on the cluster, to be able to successfully run the GitOps Update Pipeline. This change instead accepts the image details explicitly as parameters in the GitOps Update Pipeline, making it more robust and applicable to more scenarios.
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have just opened grdryn#36 to fix the tests. The explanation why the tests didn't fail here is in that PR. Now it should be OK and the tests would catch it. After that PR is merged, we can merge this too.
Update shell tests to work with gitops-update-pipeline changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approved This worked for me without issues and no requirement for a pre-existing successful pipelinerun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LaVLaS The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JIRA: https://issues.redhat.com/browse/RHOAIENG-4982
Description
Before this change, at least one PipelineRun for the specified model name from the aiedge-e2e Pipeline needed to exist on the cluster, to be able to successfully run the GitOps Update Pipeline.
This change instead accepts the image details explicitly as parameters in the GitOps Update Pipeline, making it more robust and applicable to more scenarios.
How Has This Been Tested?
Merge criteria: