Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add log level option for indexing tool #601

Merged
merged 4 commits into from Feb 22, 2024
Merged

add log level option for indexing tool #601

merged 4 commits into from Feb 22, 2024

Conversation

emmaai
Copy link
Contributor

@emmaai emmaai commented Feb 21, 2024

as the title.

  • The WARNING level is too spamming to catch the real failure on indexing.
  • Airflow dag would fail if the log chats too much

@emmaai emmaai force-pushed the control_log_level branch 2 times, most recently from 393eeaa to 2ed3954 Compare February 21, 2024 03:02
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (777b20e) 76.70% compared to head (e8b7e54) 76.71%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #601      +/-   ##
===========================================
+ Coverage    76.70%   76.71%   +0.01%     
===========================================
  Files           41       41              
  Lines         2996     2998       +2     
===========================================
+ Hits          2298     2300       +2     
  Misses         698      698              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like the log level as click option.

@emmaai
Copy link
Contributor Author

emmaai commented Feb 21, 2024

can be sure this time that I'm not "authorised" to merge.

@SpacemanPaul
Copy link
Contributor

SpacemanPaul commented Feb 22, 2024

can be sure this time that I'm not "authorised" to merge.

Well let's take another look and see if we can see why..... try now.

@emmaai emmaai merged commit 391c190 into develop Feb 22, 2024
8 checks passed
@emmaai emmaai deleted the control_log_level branch February 22, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants