Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rdparty: update dependencies #10274

Merged
merged 8 commits into from Dec 14, 2017
Merged

Conversation

alalek
Copy link
Member

@alalek alalek commented Dec 9, 2017

based on #9781 by @sturkmen72

  • zlib 1.2.11
  • libpng 1.6.34
  • libjpeg 9b
  • libtiff 4.0.9
  • webp 0.6.1

Jasper library is not updated (likely will be replaced to OpenJPEG)

OpenEXR update commits are excluded (too large with autogenerated data): https://github.com/alalek/opencv/commits/update_openexr

CMake output (Win64 builder):

--   Media I/O: 
--     ZLib:                        build (ver 1.2.11)
--     JPEG:                        build (ver 90)
--     WEBP:                        build (ver encoder: 0x020e)
--     PNG:                         build (ver 1.6.34)
--     TIFF:                        build (ver 42 - 4.0.9)
--     JPEG 2000:                   build (ver 1.900.1)
--     OpenEXR:                     build (ver 1.7.1)
allow_multiple_commits=1

@sturkmen72
Copy link
Contributor

sturkmen72 commented Dec 9, 2017

@alalek there is an issue about libpng see pnggroup/libpng#183

@alalek
Copy link
Member Author

alalek commented Dec 11, 2017

Actually I observe similar problem with my "system" libpng (default mode in OpenCV) on mentioned image:

--     PNG:                         /lib64/libpng.so (ver 1.6.28)

libpng error: IDAT: invalid distance too far back

I believe these images should be fixed instead of "supporting" of malformed inputs (which leads to applications vulnerabilities).

"pngfix" utility states this:

Various known problems in PNG files are fixed while the file is being read
The exit code says what problems were fixed. In particular the zlib error:
"invalid distance too far back"
caused by an incorrect optimization of a zlib stream is fixed in any
compressed chunk in which it is encountered. An integrity problem of the
PNG stream caused by a bug in libpng which wrote an incorrect chunk length
is also fixed. Chunk CRC errors are automatically fixed up.

BTW, Even after "pngfix" image data is still looks broken (bottom lines are lost). The same image result is with png 1.6.24 which eats this problem.

@alalek
Copy link
Member Author

alalek commented Dec 14, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants