[feat]tools-v2: Implement bs list poolset command #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hanqing Wu <wuhanqing@corp.netease.com>
caoxianfei1
force-pushed
the
tools/list-poolset
branch
from
7d8c786
to
e97bb14
Compare
|
cicheck |
caoxianfei1
approved these changes
Jan 5, 2024
montaguelhz
reviewed
Jan 5, 2024
| (*fileSizeMap)[fileInfo.poolset()] += fileInfo.length(); | ||
| } else { | ||
| (*fileSizeMap)[kDefaultPoolsetName] += fileInfo.length(); | ||
| } | ||
| return StatusCode::kOK; | ||
| } | ||
| case FileType::INODE_SNAPSHOT_PAGEFILE: { | ||
| // Do not count snapshot file size, set fileSize=0 |
There was a problem hiding this comment.
Maybe this comment can be deleted.
| phyPoolId := logicalPool.GetPhysicalPoolID() | ||
| poolsetId, ok := phyPoolToPoolset[phyPoolId] | ||
| if !ok { | ||
| err := cmderror.NewInternalCmdError(1, "physical pool not found") |
There was a problem hiding this comment.
internal error seems to be registered in internal/error/error.go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List