Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the UI code, the new repository is opencost/opencost-ui #2741

Merged
merged 5 commits into from May 15, 2024

Conversation

mattray
Copy link
Collaborator

@mattray mattray commented May 9, 2024

Do not merge until we have working packages from that repository.

The rationale for moving the UI to a separate repo is in #2468.

What does this PR change?

Does this PR relate to any other PRs?

  • no

How will this PR impact users?

  • Issues and PRs will migrate to that repository

Does this PR address any GitHub or Zendesk issues?

How was this PR tested?

  • With working UI builds from that repo.

Does this PR require changes to documentation?

  • Only around where code is located, so not user-facing.

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

  • We'll want to make 1.110.1 or 1.111.0 include this change.

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost ❌ Failed (Inspect) May 11, 2024 8:37am

@mattray
Copy link
Collaborator Author

mattray commented May 9, 2024

Looks like the UI tests need to be removed/disabled/moved.

@mattray
Copy link
Collaborator Author

mattray commented May 14, 2024

We can ignore the Vercel error, the UI's gone.

Copy link
Contributor

@mbolt35 mbolt35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…st/opencost-ui

Do not merge until we have working packages from that repository.

Signed-off-by: Matt Ray <github@mattray.dev>
Signed-off-by: Matt Ray <github@mattray.dev>
Signed-off-by: Matt Ray <github@mattray.dev>
Signed-off-by: Matt Ray <github@mattray.dev>
Signed-off-by: Matt Ray <github@mattray.dev>
@cliffcolvin cliffcolvin merged commit c87b36f into opencost:develop May 15, 2024
3 checks passed
Copy link

sonarcloud bot commented May 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Move the OpenCost UI into a separate repository
3 participants