Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set initial code owners and fill out some of README.md #1

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

dfr
Copy link
Collaborator

@dfr dfr commented Feb 2, 2024

I don't fully understand how the github maintainer model works - this probably needs other things to change to match my change to CODEOWNERS.

@samuelkarp PTAL.

@amye
Copy link

amye commented Feb 2, 2024

Well, so one thing: "Unknown owner on line 1: make sure @dch exists and has write access to the repository"

@dfr
Copy link
Collaborator Author

dfr commented Feb 2, 2024

Well, so one thing: "Unknown owner on line 1: make sure @dch exists and has write access to the repository"

For the moment, I have removed @dch from CODEOWNERS and I will follow up with him to get the right github handle.

Copy link
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small changes but otherwise LGTM.

CODEOWNERS Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
I don't fully understand how the github maintainer model works - this
probably needs other things to change to match my change to CODEOWNERS.

Signed-off-by: Doug Rabson <dfr@rabson.org>
@samuelkarp samuelkarp merged commit c702ef6 into main Feb 3, 2024
2 checks passed
@samuelkarp samuelkarp deleted the intial-readme branch February 3, 2024 08:29
@dfr
Copy link
Collaborator Author

dfr commented Feb 3, 2024

Thanks @samuelkarp. I plan to work on defining the requirements for this WG and I've put some initial ideas on an approach to jails here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants