Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go versions in release scripts #1170

Merged
merged 1 commit into from
Apr 25, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/docs-and-linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go: ['1.19', '1.20', '1.21']
# current Go releases plus the version in the go.mod are tested
go: ['1.18', '1.21', '1.22']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list has changed? should be 1.22 and two versions lower?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used to be two versions lower and I broke with that to have the two stable releases and the version that's in our go.mod.


env:
RELEASE_GO_VER: "1.22"

name: Documentation and Linting
steps:
Expand Down Expand Up @@ -41,7 +45,8 @@ jobs:
make docs

- name: documentation artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: matrix.go == env.RELEASE_GO_VER
with:
name: oci-docs
path: go/src/github.com/opencontainers/image-spec/output