Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lint): enable gci linter #1132

Closed
wants to merge 1 commit into from
Closed

ci(lint): enable gci linter #1132

wants to merge 1 commit into from

Conversation

mmorel-35
Copy link
Contributor

Order imports and places github.com/opencontainers modules at last.

Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@sudo-bmitch
Copy link
Contributor

Is there any advantage of going with the gci linter over the builtin goimports tool? E.g. goimports -w -local github.com/opencontainers . makes the same ordering change.

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Sep 28, 2023

It seems like goimports only handle the local import why gci is more flexible as you can define more rules.
But for the most common use which is to have the local import at last they behave the same way. And in that case it is more a matter of habit.

@mmorel-35 mmorel-35 closed this by deleting the head repository Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants