spec: PUT /v2/<name>/manifests/<reference> MUST include Content-Type #477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in discussion on the CNCF slack's #distribution channel:
The basic issue is that there is an ambiguity in the spec as-written where it's
not clear what the behavior should be if neither the manifest includes a
mediaType
field (since that is optional) nor the PUT request includes acontent-type
header.With this change from
SHOULD
toMUST
it's clearer that registries shouldreturn an error if there is no
Content-Type
header.If there are registries out there that don't enforce this and consequently
there are potential clients that don't include it already then it shouldn't be
difficult for those clients to issue a bug fix if they really need to be used
to push to a more strict registry.