This repository has been archived by the owner on Mar 4, 2019. It is now read-only.
Transaction uuid #660
Merged
Transaction uuid #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asood123
approved these changes
Mar 2, 2017
| amount: 999 | ||
| }; | ||
| const slug = 'testgroup'; | ||
| const transactionid = transaction.id; | ||
| const transactionuuid = transaction.uuid; |
There was a problem hiding this comment.
Usually we'd camelCase variables names with multiple words.
|
Yep but it's weird for ID and UUID. Do you write transactionID or
transactionId or transactionid? Same for transactionUuid or transactionUUID?
|
|
I usually write transactionId. transactionUuid would be more consistent but transactionUUID is easier to parse. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: opencollective/opencollective-api#769