Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TransactionQuery): Add transaction reference input as query argument #10087

Conversation

gustavlrsn
Copy link
Member

@gustavlrsn gustavlrsn commented May 7, 2024

Project: opencollective/opencollective#7343
For opencollective/opencollective#7396 to enable using the legacyId as the primary identifier in the drawer (and in the query)

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gustavlrsn and the rest of your teammates on Graphite Graphite

@gustavlrsn gustavlrsn force-pushed the 05-07-feat_transactionquery_use_transaction_reference_input_as_query_argument branch from 7067cc6 to 373a72c Compare May 7, 2024 12:55
@gustavlrsn gustavlrsn marked this pull request as ready for review May 7, 2024 12:56
@gustavlrsn gustavlrsn changed the title feat(TransactionQuery): Use transaction reference input as query argument feat(TransactionQuery): Add transaction reference input as query argument May 7, 2024
@gustavlrsn gustavlrsn requested a review from kewitz May 7, 2024 12:57
Copy link
Contributor

@kewitz kewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, for single-asset query, we expect the asset attributes to be passed as query attributes. I'm not sure if this is something we want to change but it would be more consistent to just add legacyId: number as an argument here.

@gustavlrsn gustavlrsn force-pushed the 05-07-feat_transactionquery_use_transaction_reference_input_as_query_argument branch from 373a72c to af12706 Compare May 7, 2024 13:29
@gustavlrsn gustavlrsn force-pushed the 05-07-feat_transactionquery_use_transaction_reference_input_as_query_argument branch from af12706 to 8c03f8b Compare May 7, 2024 13:37
@gustavlrsn
Copy link
Member Author

Already synced with @kewitz on Slack; just noting for future posterity this is implementing the pattern used by ExpenseQuery, OrderQuery, UpdateQuery and others, where an input reference type is used to hold the arguments.

@gustavlrsn gustavlrsn merged commit 1852984 into main May 7, 2024
19 checks passed
@gustavlrsn gustavlrsn deleted the 05-07-feat_transactionquery_use_transaction_reference_input_as_query_argument branch May 7, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants