Deprecate account.hasImage resolver (#10090)

* refact: deprecate Account.hasImage resolver * fix: add vendor default ordering
opencollective · May 15, 2024 · a8fff4c · a8fff4c
1 parent a463dff
commit a8fff4c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 13 deletions.
diff --git a/server/graphql/v2/interface/Account.ts b/server/graphql/v2/interface/Account.ts
@@ -176,10 +176,6 @@ const accountFieldsDefinition = () => ({
       },
     },
   },
-  hasImage: {
-    type: new GraphQLNonNull(GraphQLBoolean),
-    description: 'Returns whether this account has a custom image',
-  },
   backgroundImageUrl: {
     type: GraphQLString,
     args: {
@@ -1015,13 +1011,6 @@ export const AccountFields = {
       return collective.getImageUrl(args);
     },
   },
-  hasImage: {
-    type: new GraphQLNonNull(GraphQLBoolean),
-    description: 'Returns whether this account has a custom image',
-    resolve(collective) {
-      return Boolean(collective.image);
-    },
-  },
   backgroundImageUrl: {
     type: GraphQLString,
     args: {

diff --git a/server/graphql/v2/object/Host.js b/server/graphql/v2/object/Host.js
@@ -1290,7 +1290,7 @@ export const GraphQLHost = new GraphQLObjectType({
             where[Op.or] = searchTermConditions;
           }
 
-          const findArgs = { where, limit: args.limit, offset: args.offset };
+          const findArgs = { where, limit: args.limit, offset: args.offset, order: [['createdAt', 'DESC']] };
           if (args.forAccount) {
             const account = await fetchAccountWithReference(args.forAccount);
             findArgs['attributes'] = {
@@ -1303,7 +1303,7 @@ export const GraphQLHost = new GraphQLObjectType({
                 ],
               ],
             };
-            findArgs['order'] = [
+            findArgs.order = [
               [sequelize.literal('"expenseCount"'), 'DESC'],
               ['createdAt', 'DESC'],
             ];