Change segment startTime from mpeg7 to milliseconds in Tobira API
#5858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All durations in the API are transmitted as milliseconds, so this should be too. On the Tobira side we want to save it as milliseconds too, since Paella wants that anyway. This is a breaking API change and the API was already released as OC 15.5, so why no API version bump? The Tobira API is declared internal and only to be used by Tobira. And Tobira did not use it yet! So nothing can break.
JulianKniephoff
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All durations in the API are transmitted as milliseconds, so this should be too. On the Tobira side we want to save it as milliseconds too, since Paella wants that anyway.
This is a breaking API change and the API was already released as OC 15.5, so why no API version bump? The Tobira API is declared internal and only to be used by Tobira. And Tobira did not use it yet! So nothing can break.
Your pull request should…