Optimization of the $layout_id definition

[opencartbot]

We can also use the switch-case construction:

switch ($route){
	case 'product/category':
		if (isset($this->request->get['path'])) {
			$this->load->model('catalog/category');
			$path = explode('_', (string)$this->request->get['path']);
			$layout_id = $this->model_catalog_category->getLayoutId((int)end($path));
		}
		break;
	case 'product/product':
		if (isset($this->request->get['product_id'])) {
			$this->load->model('catalog/product');
			$layout_id = $this->model_catalog_product->getLayoutId((int)$this->request->get['product_id']);
		}
		break;
	case 'product/manufacturer.info':
		if (isset($this->request->get['manufacturer_id'])) {
			$this->load->model('catalog/manufacturer');
			$layout_id = $this->model_catalog_manufacturer->getLayoutId((int)$this->request->get['manufacturer_id']);
		}
		break;
	case 'information/information':
		if (isset($this->request->get['information_id'])) {
			$this->load->model('catalog/information');
			$layout_id = $this->model_catalog_information->getLayoutId((int)$this->request->get['information_id']);
		}
		break;
	case 'cms/blog.info':
		if (isset($this->request->get['article_id'])) {
			$this->load->model('cms/article');
			$layout_id = $this->model_cms_article->getLayoutId((int)$this->request->get['article_id']);
		}
		break;
}

[TheCartpenter]

How does that optimize the layout ID by simply sticking the codes together between each cases and using sticked opened brackets from the route on the top?

[opencartbot]

As soon as $layout_id is found, the script will go to the next stage and will not perform route checks in other conditions. We have 4 default positions, and each one performs these checks in turn. And I suggest interrupting checks if $layout_id is found. That's the whole logic. вт, 23 січ. 2024, 16:59 користувач TheCartpenter ***@***.***> пише:

…

How does that optimize the layout ID by simply sticking the codes together between each cases and using sticked opened brackets from the route on the top? — Reply to this email directly, view it on GitHub <#13595 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6ELIDXLVUDDNB7KZCWXXTYP7F3LAVCNFSM6AAAAABCGVABU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBWGIZTAOJWG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>