Added more missing casts on various config gets

opencart · Apr 26, 2024 · 2921241 · 2921241
1 parent 45cc7a3
commit 2921241
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/upload/admin/controller/mail/subscription.php b/upload/admin/controller/mail/subscription.php
@@ -253,8 +253,6 @@ public function transaction(string &$route, array &$args, &$output): void {
 								// Store
 								$from = $this->config->get('config_email');
 								$store_name = $this->config->get('config_name');
-								$store_url = HTTP_CATALOG;
-								$alert_email = $this->config->get('config_mail_alert_email');
 
 								if ($comment) {
 									$data['comment'] = nl2br($comment);

diff --git a/upload/catalog/controller/mail/affiliate.php b/upload/catalog/controller/mail/affiliate.php
@@ -144,7 +144,7 @@ public function alert(string &$route, array &$args, &$output): void {
 				$mail->send();
 
 				// Send to additional alert emails if new affiliate email is enabled
-				$emails = explode(',', $this->config->get('config_mail_alert_email'));
+				$emails = explode(',', (string)$this->config->get('config_mail_alert_email'));
 
 				foreach ($emails as $email) {
 					if (oc_strlen($email) > 0 && filter_var($email, FILTER_VALIDATE_EMAIL)) {

diff --git a/upload/catalog/controller/mail/order.php b/upload/catalog/controller/mail/order.php
@@ -645,7 +645,7 @@ public function alert(string &$route, array &$args): void {
 				$mail->send();
 
 				// Send to additional alert emails
-				$emails = explode(',', $this->config->get('config_mail_alert_email'));
+				$emails = explode(',', (string)$this->config->get('config_mail_alert_email'));
 
 				foreach ($emails as $email) {
 					if ($email && filter_var($email, FILTER_VALIDATE_EMAIL)) {

diff --git a/upload/catalog/controller/mail/subscription.php b/upload/catalog/controller/mail/subscription.php
@@ -545,7 +545,7 @@ public function alert(string &$route, array &$args): void {
 				$mail->send();
 
 				// Send to additional alert emails
-				$emails = explode(',', $this->config->get('config_mail_alert_email'));
+				$emails = explode(',', (string)$this->config->get('config_mail_alert_email'));
 
 				foreach ($emails as $email) {
 					if ($email && filter_var($email, FILTER_VALIDATE_EMAIL)) {