Fix compatibility with Vault plugins #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes it does |
JanMa
approved these changes
May 7, 2024
naphelps
force-pushed
the
fix-vault-plugin-compatibility
branch
from
68ea130
to
1cf66bf
Compare
cipherboy
force-pushed
the
fix-vault-plugin-compatibility
branch
from
1cf66bf
to
3d92a29
Compare
This adds Upstream (`VAULT_` prefixed) variants of all OpenBao-set variables during plugin startup, allowing plugins compiled for upstream to work with OpenBao. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
fix-vault-plugin-compatibility
branch
from
3d92a29
to
782b277
Compare
|
This should be ready now that I added a changelog entry @naphelps :-) |
naphelps
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Upstream (
VAULT_prefixed) variants of all OpenBao-set variables during plugin startup, allowing plugins compiled for upstream to work with OpenBao.This should resolve #317 (a discussion).
@DrDaveD Let me know if this works for you!