Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor compile_junos_data #50

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

tacerus
Copy link
Member

@tacerus tacerus commented Aug 16, 2023

Add ng version of script.

@tacerus tacerus added the juniper_junos-formula Everything related to the Juniper Junos formula label Aug 16, 2023
@tacerus tacerus force-pushed the refactor/juniper_junos/compile branch 2 times, most recently from c4495d0 to 6f02512 Compare August 17, 2023 01:54
@tacerus tacerus force-pushed the refactor/juniper_junos/compile branch from 03df3a0 to 58bc16c Compare January 22, 2024 16:17
@tacerus tacerus force-pushed the refactor/juniper_junos/compile branch from ef831c6 to 6509556 Compare January 29, 2024 11:16
Add ng version of script.

Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>

Add file handling to compile_junos_data_ng

- Drop backbone.yaml
- Read specified input and write to specified output

Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>

Update compile_junos_data_ng

- use Python 3.11 explicitly
- rename "port_group" attribute to "group"
- set default interface mode to "access"
- drop print statements
- drop empty VLAN ID lists from output

Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
Detect VLANs which are duplicated using names and ID numbers.
For example, if "vlan2000" and "2000" are contained in the VLAN IDs
of an interface, only keep "2000".

Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
If no role for a device is present, assume the device to be an
access switch.

Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
- correct nest the "mc" dict underneath "ae", no longer incorrectly
  write it underneath "lacp"
- facilitate trunk interfaces with the "all" VLAN ID, avoid an empty
  list being written instead

Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
Do not write a "None" description for VLANs not providing any
description in the input data.

Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
@tacerus tacerus force-pushed the refactor/juniper_junos/compile branch 2 times, most recently from 5e0a756 to 9754eda Compare February 9, 2024 19:56
@tacerus tacerus marked this pull request as ready for review February 9, 2024 19:56
Wish I recalled why this was needed.

Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
- bump copyright year
- remove development comments

Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
@tacerus tacerus force-pushed the refactor/juniper_junos/compile branch from 9754eda to 0fcb358 Compare February 9, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
juniper_junos-formula Everything related to the Juniper Junos formula
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant