Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify events text #16131

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

ncounter
Copy link
Contributor

@ncounter ncounter commented May 14, 2024

Be consistent in Notifications' text events.

Title

Try to be as closest as possible in the Notification's title:

  • description (AKA notification's configuration title)
  • subject (AKA notification's email subject)

Before it was a mix of:

  • Event was created
  • Event created
  • Event is created
  • Event has been created

After it is only:

  • Event created

Description

Align explanation text (AKA notification's configuration description)

Before it was a mix of:

  • Receive notifications of...
  • Receive notifications for...

After it is only:

  • Receive notifications for...

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label May 14, 2024
@ncounter ncounter marked this pull request as ready for review May 14, 2024 21:28
@ncounter ncounter force-pushed the unify-text-for-subscriptions branch 2 times, most recently from fea7bc5 to bec5907 Compare May 14, 2024 22:09
@ncounter ncounter changed the title Unify event titles text Unify events text May 14, 2024
@ncounter
Copy link
Contributor Author

@ncounter ncounter force-pushed the unify-text-for-subscriptions branch from c1b7776 to 655fef7 Compare May 14, 2024 22:44
@ncounter ncounter force-pushed the unify-text-for-subscriptions branch from 655fef7 to 069a9b8 Compare May 14, 2024 22:44
@danidoni danidoni merged commit 608b7bb into openSUSE:master May 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants