Introduce cache for singleton record of Configuration #16130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app will appear here: http://obs-reviewlab.opensuse.org/eduardoj-featureconfiguration_cache |
eduardoj
force-pushed
the
feature/configuration_cache
branch
2 times, most recently
from
ef0b5a9
to
ec6454c
Compare
... to access Configuration singleton
Otherwise, a modification of a field with `update_column` will not update the `updated_at` column and a cache miss will not happen.
This way, a miss in the Configuration singleton cache will happen.
eduardoj
force-pushed
the
feature/configuration_cache
branch
from
ec6454c
to
4fcf548
Compare
hennevogel
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of querying the database every time a configuration parameter is read, we make all methods of the Configuration class to pass internally through a new
fetchmethod which retrieves the Configuration singleton record from the cache.Follow up to #16123.