Drop useless NotificationPolicy::Scope #16125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hennevogel
force-pushed
the
refactoring/NotificationPolicy
branch
2 times, most recently
from
919050b
to
c2b644b
Compare
eduardoj
reviewed
May 14, 2024
hennevogel
force-pushed
the
refactoring/NotificationPolicy
branch
from
c2b644b
to
785210d
Compare
ncounter
approved these changes
May 14, 2024
There are no notifications anymore with subscriber_type 'Group' since we create a notification for every group member instead.
hennevogel
force-pushed
the
refactoring/NotificationPolicy
branch
from
68b7adf
to
30bc75c
Compare
Not via a superfluous namespaced policy that sets `ensure_logged_in`... KISS
Not via a superfluous namespaced policy that sets `ensure_logged_in`... KISS
hennevogel
force-pushed
the
refactoring/NotificationPolicy
branch
from
30bc75c
to
46bd622
Compare
|
This now escalated into #16133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no notifications anymore with subscriber_type 'Group' since we create a notification for every group member instead.