Add preview testing for AccordionReviewsComponent #16093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danidoni
force-pushed
the
add-preview-testing-for-accordion-reviews-component
branch
from
1780d1f
to
1cbaab1
Compare
saraycp
reviewed
May 9, 2024
| render(AccordionReviewsComponent.new(pending_reviews + accepted_reviews + declined_review, :review, can_handle_request: true)) | ||
| request_reviews = accepted_reviews + pending_reviews + declined_review | ||
| bs_request = BsRequest.last || FactoryBot.create(:bs_request_with_submit_action) | ||
| render(AccordionReviewsComponent.new(request_reviews, bs_request)) |
There was a problem hiding this comment.
The accordion is not visible. I'm using a re-created database filled with the test_data task.
The reason is in the policy as the Admin user is not the maintainer related to whatever request this is taking.
I think we should handle this in another way. Using factories to create the values is a good practice.
There was a problem hiding this comment.
Hm, right, this is a problem with the previews using data from the development environment... My environment is now different from the one from dev:test_data:create...
Let me fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preview for AccordionReviewsComponent was broken.
This PR fixes the preview and adds it to the test coverage to ensure it keeps from breaking again.