Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix factory build #16076

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix factory build #16076

wants to merge 3 commits into from

Conversation

bugfinder
Copy link
Member

build on factory has been broken for long enough that some specfiles are not even resolvable any more

- clearly set the version of ruby to use include the cases for bundler
  like already done for gem
- clearly use a source and setup lines in the specfile
- use service_del_postun_without_restart instead of the deprecated
  service_del_postun -n
- same as in obs-bundled-gems define the version of bundler to use
@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Apr 30, 2024
@hennevogel
Copy link
Member

Added our factory repo to the test build

@hennevogel
Copy link
Member

I'm not sure if this makes too much sense this way. The ruby version is probably more a question of O:S:U project conf.

There is this workaround

# Factory would prefer ruby3.2 atm
Ignore: ruby3.2 ruby3.2-rubygem-gem2rpm

and we also in general disabling all ruby versions except the one we are using.

## Disable gem building for everything but Ruby 3.1

Prefer: -ruby2.5-rubygem-gem2rpm
Prefer: -ruby2.1-rubygem-gem2rpm

%define _with_ruby31           1
%define _with_ruby30           0
%define _with_ruby27           0
...

@hennevogel
Copy link
Member

I've added some project conf changes. Let's see...

@bugfinder
Copy link
Member Author

well, even with adding prefers you can not guarantee that the higher ruby version is not installed
futhermore the ruby version has already been hardcoded in several places in the sources, this change
is meant to make this consistent

@hennevogel
Copy link
Member

you can not guarantee that the higher ruby version is not installed

Sure, the prefer was a workaround...

@hennevogel
Copy link
Member

you can not guarantee that the higher ruby version is not installed

Added the last bits to the project conf, factory should be working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants