Rename diff_to_superseded #15906
Draft
Rename diff_to_superseded #15906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncounter
force-pushed
the
rename-diff-to-superseded
branch
2 times, most recently
from
6291792
to
ab54942
Compare
ncounter
force-pushed
the
rename-diff-to-superseded
branch
from
ab54942
to
e1fca60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big rename of the mixed usage of
diff_to_supersededanddiff_to_superseded_idnaming:diff_to_supersededcontains theBsRequestobjectdiff_to_supersededcontains theBsRequestnumberdiff_to_superseded_idalways contains theBsRequestnumberThe name prefix represents a
diff_to, which instead is not present in the variable value.Consistently using
superseded_requestfor the Object andsuperseded_request_numberfor the number clarify the variables meaning and scope.