Spec SourceController package_command #15899
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has it's own spec now
It's one of the two 'cmd' routers in SourceController. It's complicated enough to warrant it's own spec.
|
If you are looking for a birthday/easter/eid present for me, help to reduce the |
This is already checked in SourceController#validate_target_for_package_command_exists! https://github.com/openSUSE/open-build-service/blob/becd4438ab565af5cbf65ba21fb4f90de6109866/src/api/app/controllers/source_controller.rb#L551-L555
danidoni
reviewed
Apr 2, 2024
Comment on lines
+285
to
+286
| it 'MissingParameterError' do | ||
| skip('to be tested') |
There was a problem hiding this comment.
Suggested change
| it 'MissingParameterError' do | |
| skip('to be tested') | |
| xit 'MissingParameterError' |
JFYI. You can shortcut the skips like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some day I'm going to refactor this. Before that day, this should be spec'ed