Do not crash if no _log file found #15852
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncounter
force-pushed
the
prevent-rpmlint_log-on-disabled-repos
branch
4 times, most recently
from
07c55ec
to
5e707ee
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15852 +/- ##
==========================================
- Coverage 86.09% 86.08% -0.01%
==========================================
Files 794 794
Lines 26028 26030 +2
==========================================
Hits 22408 22408
- Misses 3620 3622 +2 |
ncounter
force-pushed
the
prevent-rpmlint_log-on-disabled-repos
branch
from
5e707ee
to
299b722
Compare
eduardoj
reviewed
Mar 21, 2024
ncounter
force-pushed
the
prevent-rpmlint_log-on-disabled-repos
branch
from
93bf45f
to
63fcfdc
Compare
ncounter
force-pushed
the
prevent-rpmlint_log-on-disabled-repos
branch
from
63fcfdc
to
f088a8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15768
Backend::Api::BuildResults::Binaries.file(project, repository, architecture, package, '_log')crashes in case of_logfile is missing. This PR handle the exception and returns empty content so the default message is rendered.