Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Non-spatial meshes #1534

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

WIP: Non-spatial meshes #1534

wants to merge 12 commits into from

Conversation

franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented Oct 5, 2023 •
edited

Implements openPMD/openPMD-standard#193

TODO:

  • Forward/backward compatibility? (of API + of created datasets): No compatibility
  • Python docu
  • Maybe put a feature flag somewhere so that code can check for this via #if openPMD_HAVE_NONSPATIAL_MESHES or so
  • Set openPMD version in written datasets as "2.0"
  • Merge [WIP] Add openPMD version 2.0 to supported API versions #1551 first

Diff: https://github.com/franzpoeschel/openPMD-api/compare/prepare-openPMD-2.0..non-spatial-meshes

@franzpoeschel franzpoeschel added discussion api: new additions to the API labels Oct 5, 2023
@franzpoeschel
Copy link
Contributor Author

franzpoeschel commented Oct 18, 2023 •
edited

This PR should be split into two parts at some point:

  1. Introduction of openPMD 2.0, together with some helper functions
  2. Introduction of non-spatial meshes

The first part might then also be relevant for other PRs where breaking changes are introduced (e.g. #1493 use of abbreviated attributes by default in JSON backend)

EDIT: Done #1551

@franzpoeschel franzpoeschel force-pushed the non-spatial-meshes branch 2 times, most recently from 7534cb8 to 6d7513b Compare December 22, 2023 18:29
@franzpoeschel franzpoeschel force-pushed the non-spatial-meshes branch 3 times, most recently from d184a23 to 6045e89 Compare February 29, 2024 12:41
franzpoeschel
franzpoeschel commented Mar 12, 2024
View reviewed changes
src/Mesh.cpp

std::vector<double> Mesh::gridUnitSIPerDimension() const
{
return getAttribute("gridUnitSI").get<std::vector<double>>();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: introduce the same backwards-compatible logic as for gridUnitSI (line 330)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: new additions to the API discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@franzpoeschel